Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extend search for smbd #1410

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: extend search for smbd #1410

merged 1 commit into from
Aug 27, 2024

Conversation

philclifford
Copy link
Contributor

@philclifford philclifford commented Aug 4, 2024 •
edited
Loading

Description

add alternate test for /usr/sbin/smbd in case it is not in the user's PATH

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@mash-graz
Copy link

Perhaps we should also add again the test for the existence of the ${PUBLIC} folder in the condition chain.

@flexiondotorg flexiondotorg merged commit 1f0dc50 into quickemu-project:master Aug 27, 2024
4 checks passed
@philclifford philclifford deleted the fix-1409 branch August 27, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexiondotorg flexiondotorg flexiondotorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: smb support broken
3 participants
@philclifford @mash-graz @flexiondotorg