feat: enable self.jinja2.get_template without prefix
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbonczek
reviewed
Nov 7, 2024
MartinGauk
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Ich hatte es Dienstag vergessen noch zu erwähnen. Ich fände es besser, wenn die Templates nicht mehr im Python-Ordner liegen würden sondern im Hauptordner. Der Dateizugriff kann dann über qpy_env.packages[x].get_path erfolgen. Ich glaube der key in packages ist aktuell allerdings nicht namespace/shortname sondern irgendwas anderes.
janbritz
force-pushed
the
feat/get-templates-without-prefix
branch
2 times, most recently
from
1e53499 to
bf67709
Compare
janbritz
force-pushed
the
feat/get-templates-without-prefix
branch
from
bf67709 to
a926cec
Compare
janbritz
force-pushed
the
feat/get-templates-without-prefix
branch
from
a926cec to
fc4581f
Compare
janbritz
commented
Nov 21, 2024
larsbonczek
requested changes
Nov 26, 2024
|
Sollten wir vielleicht für Packages den Präfix |
and remove unused templates
janbritz
force-pushed
the
feat/get-templates-without-prefix
branch
from
0df6d56 to
a59a0ac
Compare
janbritz
commented
Nov 26, 2024
larsbonczek
requested changes
Dec 3, 2024
Co-authored-by: Lars Bonczek <[email protected]>
janbritz
force-pushed
the
feat/get-templates-without-prefix
branch
from
f8585de to
de96b1b
Compare
larsbonczek
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
Hängt ab von: questionpy-org/questionpy-server#125
Um im Template-Verzeichnis des aktuellen Pakets ein Template zu bekommen, kann
jinja2.get_templatedamit auch ohne einen Präfix aufgerufen werden.Außerdem ist die neue Präfix-Struktur:
@namespace/shortname. Dadruch sollen Mehrdeutigkeiten unwahrscheinlicher werden.Die Struktur entspricht nicht der des Identifiers (@namespace/shortname), da hierfür ein eigenerPrefixLoadergeschrieben werden müsste.Zusätzlich liegt der Templates-Ordner nicht mehr im Python-Ordner, sondern direkt im Hauptordner unter
/templates.