Moodle 4.4 #123
Merged
Moodle 4.4 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And minimum PHP version to 8.1 accordingly.
The moodle-extra style wants it this way now.
janbritz
approved these changes
Jul 30, 2024
MartinGauk
approved these changes
Jul 30, 2024
janbritz
added a commit
to questionpy-org/qpy-dev
that referenced
this pull request
Jul 30, 2024
and remove the creation of `.phpcs.xml` as we serve it now with questionpy-org/moodle-qtype_questionpy#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im moodle-extra phpcs-Standard gab es ein paar Änderungen. Insbesondere sollen Lang-Strings jetzt alphabetisch sortiert sein, was schon weird genug ist, dass ich dafür mal einen PR mache.
Ich habe unsere phpcs-Config auch mal in eine
phpcs.xmlgegossen, damit phpcs lokal sie auch benutzt. (Wenn wie hier beschrieben installiert)