Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transforms links that are image links #162

Closed
raae opened this issue Apr 26, 2022 · 1 comment · Fixed by #161
Closed

Transforms links that are image links #162

raae opened this issue Apr 26, 2022 · 1 comment · Fixed by #161
Assignees
@raae
Labels
bug Something isn't working released

Comments

@raae
Copy link
Member

raae commented Apr 26, 2022 

[![Tweet](https://queen.raae.codes/testimonials/gatsby-plugin-starter-ash.png)](https://twitter.com/Ash_Hitchcock/status/1471048277747548163?s=20&t=YKN2khQAbqaLSSccqculsw)

Should not be transformed.

It happens because we look for links inside root paragraphs, but do not check it they themselves do not contain nodes.
@raae raae added the bug Something isn't working label Apr 26, 2022
@raae raae self-assigned this Apr 26, 2022
@raae raae linked a pull request Apr 26, 2022 that will close this issue
fix: find only standalone text links in root paragraphs #161
Merged
@raae raae closed this as completed in #161 Apr 28, 2022
raae added a commit that referenced this issue Apr 28, 2022
@raae
feat: find only standalone text links in root paragraphs (#161)
dd60700 
* test: refactor to use markdown as test input

* test: add failing links in list test

* fix: find only standalone links in root paragraphs, fixes #160

* test: add image oEmbed link test

* fix: find only standalone text links (ie. not images), fixes #162 

* test: add test content to demo(s)
raae-bot pushed a commit that referenced this issue Apr 28, 2022
@semantic-release-bot
chore(release): 0.3.0 [skip ci]
1e75e38 
# [0.3.0](v0.2.1...v0.3.0) (2022-04-28)

### Features

* find only standalone text links in root paragraphs ([#161](#161)) ([dd60700](dd60700)), closes [#160](#160) [#162](#162)
@raae-bot
Copy link

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@raae raae mentioned this issue Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raae raae

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: find only standalone text links in root paragraphs queen-raae/gatsby-remark-oembed
2 participants
@raae @raae-bot