Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dockerfile): upgrade golang in upstream Dockerfile #529

Merged

Conversation

flavianmissi
Copy link
Contributor

@flavianmissi flavianmissi commented Sep 20, 2021

This matches the golang version with Dockerfile @ master. Project doesn't build with with golang 1.13, see kubernetes-sigs/cluster-api#4096

FTR, here's the error:

Step 10/15 : RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -mod vendor -o manager main.go
 ---> Running in 7b4f402b9966
# sigs.k8s.io/controller-runtime/pkg/manager
vendor/sigs.k8s.io/controller-runtime/pkg/manager/manager.go:53:2: duplicate method Start
The command '/bin/sh -c CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -mod vendor -o manager main.go' returned a non-zero code: 2

Error: Process completed with exit code 2.

Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM!

@flavianmissi flavianmissi merged commit a32d1b4 into quay:redhat-3.5 Sep 20, 2021
@flavianmissi flavianmissi deleted the dockerfile-upgrade-golang branch September 20, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants