Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman client support #8

Merged
merged 9 commits into from
Nov 30, 2020
Merged

Add podman client support #8

merged 9 commits into from
Nov 30, 2020

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Nov 17, 2020

https://issues.redhat.com/browse/PROJQUAY-1295

Add support to use Podman as the container engine.

@kleesc kleesc marked this pull request as draft November 17, 2020 15:39
@kleesc kleesc force-pushed the add-podman-client branch 5 times, most recently from 46acee8 to 3a557a5 Compare November 19, 2020 15:55
@kleesc kleesc marked this pull request as ready for review November 19, 2020 16:41
@kleesc kleesc changed the title WIP: Add podman client Add podman client support Nov 19, 2020
@kleesc kleesc force-pushed the add-podman-client branch 2 times, most recently from c6ed119 to a398986 Compare November 25, 2020 22:21
@kleesc kleesc force-pushed the add-podman-client branch 2 times, most recently from bdea3b1 to 1f6a9c3 Compare November 26, 2020 19:31
- Interface the different container runtimes.
- Adds GRPC TLS flags. Allow the grpc client to either:
  - Use a cert specified by the CERT_FILE env var
  - Use an insecure GRPC connection using the INSECURE env var
  - Use the system's default certs t connect to the GRPC server.
Also removes the workaround to build github.com/moby/buildkit on darwin.
Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleesc kleesc merged commit 42d8d5e into master Nov 30, 2020
@kleesc kleesc deleted the add-podman-client branch November 30, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants