Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Quota Reporting and Management #12

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

Sunandadadi
Copy link
Contributor

No description provided.

@Sunandadadi Sunandadadi changed the title WIP: Proposal for Quota Reporting and Management [WIP] Proposal for Quota Reporting and Management Dec 3, 2021
@Sunandadadi Sunandadadi changed the title [WIP] Proposal for Quota Reporting and Management Proposal for Quota Reporting and Management Dec 6, 2021
@Sunandadadi Sunandadadi force-pushed the quota_proposal branch 3 times, most recently from 3d249e0 to a3e6ee7 Compare December 9, 2021 15:13
enhancements/quota-management.md Show resolved Hide resolved
enhancements/quota-management.md Outdated Show resolved Hide resolved
enhancements/quota-management.md Outdated Show resolved Hide resolved
This is depicted below:
![](https://user-images.githubusercontent.com/11522230/145113938-7a8e3fcf-693a-488e-a711-bcf116e04446.png)

### Risks and Mitigations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few caveats with doing the calculations on push vs a background worker: existing images will not have any usage data. This means that a backfill for all existing repositories will be required before the feature is enabled. This also means that this calculation becomes part of a push's critical path, otherwise the usage data could possibly drift.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try and define how to reconcile different states of a Quay installation into one where quota reporting can be enabled. For example, what happens if a user enables quota reporting, disables it and reanables it, etc, ...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data required exists on all old data already. This new path does not become critical as the data comes from elsewhere the reporting can fall back upon slower methods of reporting if it becomes necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding enabling and disabling Quota: I am thinking in the terms of having a button on an organization say Sync Quota when Quota is enabled. When clicked, we calculate the Quota usage for the org and show. If user disables, Quota is not calculated after disabling, but when re-enabled again, they have the option to sync it back.
But, if hard limits are configured and user disables Quota, I am assuming that the limits should not hold true and the user can push images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants