-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for Quota Reporting and Management #12
Conversation
9fcceab
to
77a2d1d
Compare
3d249e0
to
a3e6ee7
Compare
This is depicted below: | ||
![](https://user-images.githubusercontent.com/11522230/145113938-7a8e3fcf-693a-488e-a711-bcf116e04446.png) | ||
|
||
### Risks and Mitigations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few caveats with doing the calculations on push vs a background worker: existing images will not have any usage data. This means that a backfill for all existing repositories will be required before the feature is enabled. This also means that this calculation becomes part of a push's critical path, otherwise the usage data could possibly drift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try and define how to reconcile different states of a Quay installation into one where quota reporting can be enabled. For example, what happens if a user enables quota reporting, disables it and reanables it, etc, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data required exists on all old data already. This new path does not become critical as the data comes from elsewhere the reporting can fall back upon slower methods of reporting if it becomes necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding enabling and disabling Quota: I am thinking in the terms of having a button on an organization say Sync Quota
when Quota is enabled. When clicked, we calculate the Quota usage for the org and show. If user disables, Quota is not calculated after disabling, but when re-enabled again, they have the option to sync it back.
But, if hard limits are configured and user disables Quota, I am assuming that the limits should not hold true and the user can push images.
a3e6ee7
to
7cee773
Compare
No description provided.