[WIP] volume: Volume Size Override Proposal (PROJQUAY-1090) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathankingfc
commented
Nov 1, 2021
jonathankingfc
commented
- Volume Size Override Proposal
- Volume Size Override Proposal
jonathankingfc
changed the title
ricardomaraschini
suggested changes
Nov 15, 2021
There was a problem hiding this comment.
@jonathankingfc I think that we gonna need more details into this Enhancement Proposal before we move on. It would be vital to have here a proposal for the actual implementation (it does not need to be the right implementation, but one that should work and that we can start working on). You gonna need to answer here questions as:
- How will the CRD spec look like ?
- How will the CRD status look like (when users enter override values and when they don't) ?
- What is the expected behavior for the operator when an user asks for shrinking and existing storage ?
- Can we shrink? What should we be worried about?
- Are we going to need more Conditions (component conditions) to support this feature ?
| This is where to call out areas of the design that require closure before deciding | ||
| to implement the design. For instance, | ||
|
|
||
| > 1. Where should the configuration options be presented to the end user? In the CR? Or should they be applying a patch? |
There was a problem hiding this comment.
I think that to answer this question is one of the goals of this enhancement proposal.
| ### Goals | ||
|
|
||
| - Creating a zero-config `QuayRegistry` on OpenShift will be use default PVC sizes for the ObjectStorage, Clair, and Postgres components | ||
| - Creating a `QuayRegistry` with volumeSizeOverride fields under the ObjectStorage, Clair, or Postgres managed components will override the default size |
There was a problem hiding this comment.
How the CR would look like under this situation? Can you write down an example here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.