Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index off by one error for flux percential ratio #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenstetzler
Copy link

Here's the PR. Perhaps it would be good to rename

lc_length = len(sorted_data) - 1

F_60_index = int(math.ceil(0.60 * lc_length))
...

to

lc_length = len(sorted_data)
lc_index = lc_length - 1

F_60_index = int(math.ceil(0.60 * lc_index))
...

or to

lc_index = len(sorted_data) - 1

F_60_index = int(math.ceil(0.60 * lc_index))
...

to keep the semantics of the variable lc_length consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants