ruleguard/typematch: implement struct type pattern matching

[quasilyte]

struct{$*_} - arbitrary struct
struct{$_; $_} - struct of any 2 fields
struct{$x; $x} - struct of 2 fields of type $x
struct{$*_; $x} - struct that ends with $x-typed field
struct{$x; $*_} - struct that starts with $x-typed field
struct{$*_; $x; $*_} - struct that contains $x-typed field

This is not a direct solution for https://twitter.com/dgryski/status/1317245210041012224,
but it makes us get a little closer to it.

There are several interpretations of Type.Contains() and we need
to decide what should be traversed and whatnot (and how deep).

Until we decide on the exact Type.Contains() semantics, struct
type pattern matching can be a temporary solution to this problem.

I'll add analyzer tests later to see whether it really can be
used in the requested context. I would expect that we need
things like Type.Underlying(), etc. to make it work correctly.
But that's a different story.

Signed-off-by: Iskander Sharipov [email protected]

[quasilyte]

I'll update the docs when it will be clear that this typematch package feature can be used from rules without any modifications.

[cristaloleg]

probably can be moved above, to prevent parsing when we don't have field.Names

[cristaloleg]

just return thing func call? :)

[dgryski]

/cc @robskillington

[quasilyte]

I think we still need something like Type.Contains:

m["x"].Type.Is(`map[time.Time]$_`)

It will match all maps where key type is time.Time, but it won't handle cases where we want a key underlying type to be time.Time. Contains() could be a simple way to get away with inability to apply a nested type filter/constraint.

Or maybe type expression vars should be available in consequent where operands:

m["x"].Type.Is(`map[$key]$_`) && m["key"].Type.Underlying().Is(`time.Time`)

Although m["key"] is not the best candidate as it would yield fluent.Var type, but it probably should be a TypeExpr.