Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI ang go1.22 support #479

Merged
merged 3 commits into from
Aug 23, 2024
Merged

chore: fix CI ang go1.22 support #479

merged 3 commits into from
Aug 23, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Aug 22, 2024

  • update golangci-lint to v1.60.2 (go1.23 support)
  • fix golangci-lint configuration
  • fix go-critic reports

@ldez
Copy link
Contributor Author

ldez commented Aug 22, 2024

The current failure is related to #478 because the modification is only supported by go1.23.

 internal/xtypes/xtypes.go:1: : # github.com/quasilyte/go-ruleguard/internal/xtypes
Error: internal/xtypes/xtypes.go:226:26: x.Rhs undefined (type *types.Alias has no field or method Rhs) (typecheck)
package xtypes
Error: ruleguard/filters.go:14:2: could not import github.com/quasilyte/go-ruleguard/internal/xtypes (-: # github.com/quasilyte/go-ruleguard/internal/xtypes
Error: internal/xtypes/xtypes.go:226:26: x.Rhs undefined (type *types.Alias has no field or method Rhs)) (typecheck)
	"github.com/quasilyte/go-ruleguard/internal/xtypes"
	^
Error: ruleguard/typematch/typematch.go:12:2: could not import github.com/quasilyte/go-ruleguard/internal/xtypes (-: # github.com/quasilyte/go-ruleguard/internal/xtypes
Error: internal/xtypes/xtypes.go:226:26: x.Rhs undefined (type *types.Alias has no field or method Rhs)) (typecheck)
	"github.com/quasilyte/go-ruleguard/internal/xtypes"
	^

@ldez ldez changed the title chore: fix CI chore: fix CI ang go1.22 support Aug 22, 2024
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quasilyte quasilyte merged commit 0fe6f58 into quasilyte:master Aug 23, 2024
2 checks passed
@ldez ldez deleted the fix/ci branch August 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants