gogrep: update gogrep code (from upstream) + rewrite tests (#198)

quasilyte · Feb 1, 2021 · 0391c99 · 0391c99
1 parent 4f0d57f
commit 0391c99
Show file tree

Hide file tree

Showing 4 changed files with 421 additions and 5 deletions.
diff --git a/analyzer/testdata/src/extra/rules.go b/analyzer/testdata/src/extra/rules.go
@@ -156,8 +156,10 @@ func testRules(m dsl.Matcher) {
 	m.Match(`if len($xs) != 0 { for range $xs { $*_ } }`,
 		`if len($xs) != 0 { for $i := range $xs { $*_ } }`,
 		`if len($xs) != 0 { for _, $x := range $xs { $*_ } }`,
+		`if len($xs) != 0 { for _, $x = range $xs { $*_ } }`,
 		`if $xs != nil { for range $xs { $*_ } }`,
 		`if $xs != nil { for $i := range $xs { $*_ } }`,
-		`if $xs != nil { for _, $x := range $xs { $*_ } }`).
+		`if $xs != nil { for _, $x := range $xs { $*_ } }`,
+		`if $xs != nil { for _, $x = range $xs { $*_ } }`).
 		Report(`check on $xs is redundant, empty/nil slices and maps can be safely iterated`)
 }