-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app/capacitor): upgrade to capacitor 2.0, fixes #5823 #6808
feat(app/capacitor): upgrade to capacitor 2.0, fixes #5823 #6808
Conversation
This is great, thank you! You might want to change the hard coded path here to the real ones, because the path is only valid if the capacitor or cordova id has not been modified. |
@J3m5 My latest commit should have fixed that issue, it uses a glob to automatically find the proper path. If you could test it out that would be awesome. |
I'll try to test it today and keep you posted. |
@J3m5 hey there! Did you find the time to test this? |
Hey ! |
So, I've tested it, it handles the self signed certificate errors correctly but it still doesn't solve the problem of missing cordova and capacitor runtime in the index.html file that is served to the client. Like I previously said in issue #6771, I don't think it is strictly related to the ssl errors, but it has more to do with two possible things:
|
I think we could merge this and deal with the ssl error in another PR to resolve the issues caused by the capacitor upgrade problems. |
Merging, testing, and adapting to q/app v2. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
This PR will use a new method to enable https support for capacitor. It is only available since version 1.5.1 of capacitor. In addition, new projects created will use capacitor 2.0. Other than the https issue, it will work with existing pre-2.0 capacitor projects. I can add in a check to use the old https method for pre-1.5.1 projects to mitigate the breaking change.
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Dev/build process stays the same. Have not testing for IOS, someone has to before this gets merged. Also need someone to test that native plugins still work with https enabled.