Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Datetime use min and max properties for year processing #501

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

NoumirPoutipou
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR corrects a bug in Datetime component, it is impossible to select a date lower than 1950 on q-inline-datetime component.
Even with min property correctly set.
Same behavior for max property.

How to reproduce:

  1. Use a component like this:
<q-inline-datetime v-model="birthday" type="date" min="1900-01-01T00:00:00.000Z">
</q-inline-datetime>
  1. Click on the year
  2. Select a year lower than 1950 (let's say 1930)
  3. Date is automatically set back to 1950.

Note

My noob level in quasar do not allow me to test it under cordova/electron... sorry for that... :)

@rstoenescu rstoenescu merged commit f924170 into quasarframework:dev Apr 3, 2017
@rstoenescu
Copy link
Member

Nice catch. Thanks for taking time for a PR.

@rstoenescu
Copy link
Member

Available in edge and future v0.14.

@rstoenescu rstoenescu added this to the v0.14 milestone Apr 3, 2017
@NoumirPoutipou
Copy link
Contributor Author

Thanks! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants