Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #3193

Merged
merged 1 commit into from
Feb 9, 2019
Merged

typo #3193

merged 1 commit into from
Feb 9, 2019

Conversation

jmellicker
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@rstoenescu rstoenescu merged commit 95108c9 into quasarframework:dev Feb 9, 2019
@rstoenescu
Copy link
Member

Thx, Josh!

@jmellicker
Copy link
Contributor Author

@rstoenescu so excited to dive into 1.0!!!

🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼 🌟 👏🏼

Everything looks awesome—new website header, and the new docs are OMG OMG OMG amazing!!!!

Once things settle down for you, hope we can have a chat!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants