Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu drawer isn't defined enough (desktop) #364

Closed
Async0x42 opened this issue Feb 1, 2017 · 6 comments
Closed

Menu drawer isn't defined enough (desktop) #364

Async0x42 opened this issue Feb 1, 2017 · 6 comments

Comments

@Async0x42
Copy link

I find that the default drawer could be improved a little with some bordering or a shade, or something. It's often bothered me in the past, but it's really noticeable when compared to the same layout in other libraries.

I think it's the large amount of white-space on large desktop screens that makes it less attractive, since because mobile has the dimmer to make it stand out.

Quasar:
image

Vuetify:
image

@rstoenescu
Copy link
Member

You can add it by CSS in your app, but will see about it in Quasar directly. Thanks!

@smolinari
Copy link
Collaborator

Sounds like it may be "contributor friendly" too? 😄

Scott

@rstoenescu
Copy link
Member

@smolinari Yep.

@rstoenescu
Copy link
Member

Pushed commit. Available in edge and next version after v0.13.

Added screenshot with Material theme. Using box-shadow. On iOS it's used a border instead of box-shadow to get in line with toolbars.

screenshot from 2017-02-01 19 20 48

Thanks for submitting this issue. Comments?

@smolinari
Copy link
Collaborator

Looks pretty sharp to me. 😄

Scott

@Async0x42
Copy link
Author

Big improvement, great!

@rstoenescu rstoenescu added this to the v0.13.1 milestone Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants