Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #113 - test errors caused by missing quasar components #114

Closed
wants to merge 1 commit into from

Conversation

geoidesic
Copy link

when using mountQuasar method

#113

What kind of change does this PR introduce? (check at least one)

  • [x ] Bugfix
  • New test runner
  • Documentation
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

If you are adding a new test runner, have you...? (check all)

  • Created an issue first?
  • Registered it in /packages/base/runners.json?
  • Added it to /README.md?
  • Included one test that runs baseline.spec.vue?
  • Added and updated documentation?
  • Included a recipe folder with properly building quasar project?

Does this PR introduce a breaking change? (check one)

  • Yes
  • [x ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x ] It's submitted to the dev branch and not the master branch
  • [x ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on Windows
  • It's been tested on Linux
  • [x ] It's been tested on MacOS
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@mateonunez
Copy link

This PR is working.
Thanks, it was hepful!

@@ -3,7 +3,15 @@ import { createLocalVue, shallowMount } from 'test-utils'

import Vuex from 'vuex'
import VueRouter from 'vue-router'
import Quasar, { Cookies } from 'quasar'
import * as All from 'quasar'
const { Quasar, cookies } = All
Copy link
Contributor

@Blfrg Blfrg Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe cookies should be Cookies
To be referenced by this line

@Blfrg
Copy link
Contributor

Blfrg commented Jul 20, 2020

  • It's been tested on Linux
  • It fixes the issue

@IlCallo
Copy link
Member

IlCallo commented Sep 11, 2020

Superseded by #117

@IlCallo IlCallo closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants