Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

fix(ts): 🐛 remove trailing comma in tsconfig.json #133

Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix(ts): 🐛 remove trailing comma in tsconfig.json #133

merged 1 commit into from
Sep 8, 2020

Conversation

Blfrg
Copy link
Contributor

@Blfrg Blfrg commented Sep 7, 2020

As discussed in quasar-testing/pull/117
When installing @quasar/testing-unit-jest with Typescript support it attempts to modify the tsconfig.json but a parsing error occurs.
Removing this trailing comma by default will help ensure new Quasar projects based on the starter kit will not experience the same error.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

As discussed in [quasar-testing/pull/117](quasarframework/quasar-testing#117 (comment))
When installing `@quasar/testing-unit-jest` with Typescript support it attempts to modify the `tsconfig.json` but a parsing error occurs.
Removing this trailing comma by default will help ensure new Quasar projects based on the starter kit will not experience the same error.
@IlCallo IlCallo merged commit 2252085 into quasarframework:dev Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants