Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the jobs recovering (on scheduler startup) blocks simple trigger after failover situation for job which was executing during JVM crash #94

Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2016

Fix for #93

…rtup) blocks simple trigger after failover situation for job which was executing during JVM crash
@jhouserizer
Copy link
Contributor

Hi @eugene-goroschenya ,

This contribution falls under the conditions described under the heading "Contributions which do require a full Contributor’s License Agreement (CLA)" here: http://www.quartz-scheduler.org/community/contribute.html

We very much appreciate your contribution, and request that you submit a signed agreement.

Thanks!

@ghost
Copy link
Author

ghost commented Jan 13, 2017

Hello @jhouserizer

CLA was provided to [email protected]

See email sent by Hannelore Schubert on 11.01.2017, subject - Open Source Software Library "Quartz".

@zemian
Copy link
Contributor

zemian commented Jan 14, 2017

Oh wow, this is bad bug, and thanks a lot @eugene-goroschenya for the fix!

My only minor comment is that in RecoverJobsTest line 84, I would suggest we should close the DB connection that used after DB check. Closing just Statement is not clean enough.

Also since RecoverJobsTestJob is only used in RecoverJobsTest, I would suggest we create a inner class in RecoverJobsTest instead of under the full package.

@jhouserizer is the CLA all good and can we merge once it's ready?

@jhouserizer
Copy link
Contributor

Obviously we'll want this in trunk also.

@zemian
Copy link
Contributor

zemian commented Jan 16, 2017

I have some free time now, so I will help merge this in and port to trunk.

@zemian zemian merged commit 76d4923 into quartz-scheduler:quartz-2.2.x Jan 16, 2017
@egoroschenya-sc
Copy link

Hi @jhouserizer and @zemian

Thanks for reviewing and merging PR quite fast.

Any plans to release quartz-2.2.4 bugfix version?

We are looking forward the official quartz version where this bug has been fixed.

@JochenFrankeOC
Copy link

Dear @jhouserizer and @zemian,
is an offical quartz quartz-2.2.4 release containing the fix of this issue scheduled?
The bug causes problems in our software and we need plan our strategy of solving them.

@jhouserizer jhouserizer added this to the 2.3.0 milestone Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants