Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Cannot create tables in MySQL with InnoDB and UTF8mb4" #7

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

krrg
Copy link

@krrg krrg commented May 2, 2016

See #6

@disaacson
Copy link

I wouldn't mind if these fields were even smaller. 380 total characters for an identifier is pretty large. Should we reduce the size to 100 chars wide?

@krrg
Copy link
Author

krrg commented Jun 17, 2016

I can't imagine a situation in which a 190 character identifier would be needed or would be valuable.

@jhouserizer
Copy link
Contributor

Hi, thank you very much for your interest in contributing to the project! Please read about submitting contributions here: http://www.quartz-scheduler.org/community/contribute.html and confirm in a reply comment that you agree to the grant statement under the heading "Agreement and Grant of Copyright"

@poojits
Copy link

poojits commented Oct 11, 2016

CALENDAR_NAME should also be changed toVARCHAR(190) in QRTZ_TRIGGERS and QRTZ_CALENDARS as there are indices on CALENDAR_NAME as well.
And INSTANCE_NAME, JOB_NAME, JOB_GROUP to VARCHAR(190) in QRTZ_FIRED_TRIGGERS. Also, one should modify tables_mysql_innodb.sql.

@zemian
Copy link
Contributor

zemian commented Oct 12, 2016

Thanks for the PR @krrg
Since these are InnoDB specific, can you modify your PR to tables_mysql_innodb.sql file instead? We can leave the original tables_mysql.sql if that does not bother anyone. Also can you please also update the ones mentioned by @poojits ?

@krrg
Copy link
Author

krrg commented Oct 12, 2016

@jhouserizer I agree to the grant statement.

I'll go ahead and implement the changes listed by @poojits and move the changes into the tables_mysql_innodb.sql and update the PR as soon as I have a spare cycle (should be today).

@zemian
Copy link
Contributor

zemian commented Oct 13, 2016

Looks good @krrg Thanks for the contribution!

@zemian zemian merged commit 71a1509 into quartz-scheduler:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants