Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1161 Add Oracle23 SQL script using BOOLEAN #1221

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

melloware
Copy link
Contributor

Fix #1161 Add Oracle23 SQL script using BOOLEAN

Oracle 23 uses BOOLEAN instead of VARCHAR2(1)

@bcode2
Copy link
Contributor

bcode2 commented Oct 18, 2024

Should we worry about getboolean()?. Seem that true/false may be a problem?

https://github.com/openjdk-mirror/jdk/blob/jdk8u/jdk8u/master/src/share/classes/java/sql/ResultSet.java

@melloware
Copy link
Contributor Author

Good question. We have this discussion going on quarkusio/quarkus#43720 (comment)

And I have been running fine with these changes as well so i think its all working

@bcode2
Copy link
Contributor

bcode2 commented Oct 18, 2024

Perfect!!!!!! @melloware 👍

@jhouserizer
Copy link
Contributor

Thanks!

@jhouserizer jhouserizer added this to the Quartz 2.5.0 Release milestone Oct 23, 2024
@jhouserizer jhouserizer merged commit b352e84 into quartz-scheduler:main Oct 23, 2024
5 checks passed
@melloware melloware deleted the patch-1 branch October 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Oracle 23] VARCHAR2(1) breaking change
3 participants