Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fixes for checkdoc and byte compiler #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sje30
Copy link

@sje30 sje30 commented Feb 11, 2023

Hi,
I've made a few docstring edits to pass checkdoc and also byte compiler warnings.

There are some remaining 'byte compiler' warnings, below. Would you be interested in a patch to clear them up (although first two at not at first glance obvious to me)?

quarto-mode.el:56:22: Warning: ‘make-variable-buffer-local’ not called at
    toplevel
quarto-mode.el:62:20: Warning: ‘make-variable-buffer-local’ not called at
    toplevel

In quarto-preview:
quarto-mode.el:217:11: Warning: Unused lexical variable `browser-path'

In quarto-mode--preview-refresh-complete:
quarto-mode.el:248:11: Warning: Unused lexical variable `data'
quarto-mode.el:248:25: Warning: Unused lexical variable `symbol-status'
quarto-mode.el:248:39: Warning: Unused lexical variable `error-thrown'

In quarto-mode--maybe-preview:
quarto-mode.el:261:13: Warning: Unused lexical variable
    `this-project-directory'

@cscheid
Copy link
Contributor

cscheid commented Feb 12, 2023

Yes, we would appreciate further PRs! (Also note that I ran our melpazoid workflow and it failed for this PR. but for a strange reason in setup-python that I don't fully understand right now. My availability for this kind of work will unfortunately only be in a few weeks, but I will check in on this issue in the meantime.)

@7yl4r 7yl4r mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants