Update revealjs v5 and dependencies #10361
Conversation
|
This looks great! Keeping in mind the upcoming posit::conf presentations, we should either:
What do you think? |
|
😄 definitely the main question. I ask myself the same, hence the draft state. We have a stable release working we could also consider that anyone doing a presentation for "production" (posit::conf) would use a stable version and not a pre-release 😉 Though our users likes to live on the edge of new stuff ! 😆 I don't think the effect if big, but we don't really have test regarding how feature works in in a live browser situation so it requires manual testing. And I am just starting them. Could be small or no effect, but could also be the opposite 🤷♂️. So considering the milestone of conf, we should probably let this in a branch. This also leave me time to add to this, rebasing often on main and adding some tests. What is your take on this ? |
|
You have the hands-on experience.
That works for me. Let's plan to merge right after conf. |
cderv
force-pushed
the
revealjs/update-v5
branch
2 times, most recently
from
1a9fdb8
to
4dcc897
Compare
cderv
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
Nevermind, it seems it is fixed upstream: We need an unreleased version of chalkboard. |
cderv
force-pushed
the
revealjs/update-v5
branch
from
21a5877
to
8e4eea4
Compare
- revealjs 5.0.5 - chalkboard 4.2.5
they use default and dark and are adapted
This is useful to check the variable inclusion
otherwise error with leftover files and ignore whitespace
this is an unreleased version with a fix for Reveal.js 5.0.3 change regarding overlay styling
cderv
force-pushed
the
revealjs/update-v5
branch
from
8e4eea4
to
dcd1724
Compare
[skip ci]
|
Very small theme change after all, and it is now more inline with revealjs own theme. All good to merge this PR so I'll go ahead. I'll update documentation for 1.6 to close #4795 , including adding an highlight |
Towards
Update Revealjs to latest version 5 #4795
Revealjs 5.1.0, new JS and themes
Reveal Plugins 4.2.5 for chalkboard 2.3.3
This PR includes docs and process to update revealjs theming. It helps understand how this currently works to maps Sass variables from user's theming, to quarto internals, and then to expected Reveal.js own SASS theming system.
We probably need more tests as most of the change will have effect in browser running JS code for reveal, so we don't have much test with this yet.
Manual testing