Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new miniconf (trait split) #767

Merged
merged 21 commits into from
Sep 6, 2023
Merged

new miniconf (trait split) #767

merged 21 commits into from
Sep 6, 2023

Conversation

jordens
Copy link
Member

@jordens jordens commented Aug 10, 2023

No description provided.

src/bin/dual-iir.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the changes-hitl Changes HITL scripts, needs close review label Aug 21, 2023
hitl/loopback.py Outdated Show resolved Hide resolved
@jordens jordens marked this pull request as ready for review September 5, 2023 14:16
@jordens jordens added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@jordens jordens added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@ryan-summers ryan-summers added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@ryan-summers
Copy link
Member

Reposting some of my information here. The HITL appears to be failing because the QUARTIQ office network has two addresses assigned to the mqtt name:

rsummers@irvine:/home/runner$ host -t a mqtt
mqtt.ber.quartiq.de is an alias for baby.ber.quartiq.de.
baby.ber.quartiq.de has address 10.34.17.1
baby.ber.quartiq.de has address 10.34.16.1

rsummers@irvine:/home/runner$ host -v -t a mqtt
Trying "mqtt.ber.quartiq.de"
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 52636
;; flags: qr aa rd ra; QUERY: 1, ANSWER: 3, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;mqtt.ber.quartiq.de.           IN      A

;; ANSWER SECTION:
mqtt.ber.quartiq.de.    0       IN      CNAME   baby.ber.quartiq.de.
baby.ber.quartiq.de.    0       IN      A       10.34.17.1
baby.ber.quartiq.de.    0       IN      A       10.34.16.1

Received 102 bytes from fd60:7da2:8519:16::1#53 in 0 ms

The 10.34.17.1 address is provided first in the list, and pinging this address is successful, but it does not appear that there is an MQTT broker running on this machine. As such, the HITL is failing because Stabilizer is getting a bad IP address from DNS. Once we fix the DNS configuration, I believe HITL should succeed.

@jordens
Copy link
Member Author

jordens commented Sep 6, 2023

Presumably Smoltcp should prefer the shortest route which is the .16.1 in this case. But I'll fix it for this case.

Also we should also investigate srv record support and then use that as default.

@ryan-summers
Copy link
Member

Presumably Smoltcp should prefer the shortest route which is the .16.1 in this case. But I'll fix it for this case.

I'm not sure how it would detect the "shortest" path route. Technically, smoltcp will give you all of the routes, we just have it configured to only provide the first. I also have the NAL set up to only handle a single (first) result. How would you propose software identifies the "shortest" route. Would this be the "smallest" subnet that could be made between the device and the domain name?

Also we should also investigate srv record support and then use that as default.

Hmm, I don't think the embedded-nal traits support providing a fully-qualified IP+port address back from the query currently, so this would require a NAL update as well.

@jordens
Copy link
Member Author

jordens commented Sep 6, 2023

Presumably Smoltcp should prefer the shortest route which is the .16.1 in this case. But I'll fix it for this case.

I'm not sure how it would detect the "shortest" path route. Technically, smoltcp will give you all of the routes, we just have it configured to only provide the first.

All of the routes?
The route to .16.1. needs zero hops while the one to .17.1 needs to go via the default route. Smoltcp knows that.
It's also should not discard records from the NS response but preferrably do something like happy eyes (what browsers do).

I also have the NAL set up to only handle a single (first) result. How would you propose software identifies the "shortest" route. Would this be the "smallest" subnet that could be made between the device and the domain name?

on-link IP addresses should be preferred to those that need to go via the gateway.

Also we should also investigate srv record support and then use that as default.

Hmm, I don't think the embedded-nal traits support providing a fully-qualified IP+port address back from the query currently, so this would require a NAL update as well.

Yes. It's a further usability improvement step that came to mind. Independent of this issue.
It's also what mosquitto does.

@jordens jordens added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit b2f11b4 Sep 6, 2023
8 of 9 checks passed
@jordens jordens deleted the miniconf branch September 6, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-hitl Changes HITL scripts, needs close review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants