Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post on Jlama integration #2182

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add post on Jlama integration #2182

merged 1 commit into from
Dec 4, 2024

Conversation

mariofusco
Copy link
Contributor

Copy link

github-actions bot commented Nov 29, 2024

🙈 The PR is closed and the preview is expired.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

I have added a few initial comments

_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Show resolved Hide resolved
@mariofusco
Copy link
Contributor Author

@geoand Thanks for your feedback. I've incorporated all your suggestions, please review again.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s fantastic! I’ve made a few minor comments.

I’m wondering if attaching a recording of the demonstration would not bring more awareness.

_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
_posts/2024-11-29-quarkus-jlama.adoc Outdated Show resolved Hide resolved
@mariofusco
Copy link
Contributor Author

@cescoffier I applied your suggestions to the article, thanks a lot. However wait before merging this: I also want to record a quick demo video and link it to the post. I will work on this tomorrow.

@mariofusco
Copy link
Contributor Author

@cescoffier I also added a video to demonstrate how the application works. I believe this is ready to be merged now, please give it a final review.

---
layout: post
title: "Creating pure Java LLM infused application with Quarkus, Langchain4j and Jlama"
date: 2024-11-29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariofusco can you update the date and then we are good to go.

Without it may appear behind some other posts.

@cescoffier
Copy link
Member

The video is great! Love the sound of the fan :-)

@mariofusco
Copy link
Contributor Author

The video is great! Love the sound of the fan :-)

I had to speed up the part when it does the download of the model and that made the noise even worse 😄

@mariofusco
Copy link
Contributor Author

Any reason why we are holding this?

@geoand
Copy link
Contributor

geoand commented Dec 4, 2024

Yeah, we forgot about it 😁

@geoand geoand merged commit 521b56a into quarkusio:main Dec 4, 2024
1 check passed
@mariofusco mariofusco deleted the jlama branch December 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants