Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog on java 17 #1845

Merged
merged 5 commits into from
Nov 30, 2023
Merged

blog on java 17 #1845

merged 5 commits into from
Nov 30, 2023

Conversation

maxandersen
Copy link
Member

@maxandersen maxandersen commented Nov 29, 2023

draft for java 17 blog - 90% complete - posting as draft for feedback. will be out for some hours and come back in afternoon.

Copy link

github-actions bot commented Nov 29, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I suggested a few adjustments.

_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
_posts/2023-11-29-java-17.adoc Outdated Show resolved Hide resolved
@maxandersen maxandersen marked this pull request as ready for review November 29, 2023 17:00
@maxandersen
Copy link
Member Author

@gsmet thanks - I incorporated your suggestions and added a few more details.

@maxandersen maxandersen merged commit 844e82c into quarkusio:develop Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants