Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related content to guides #1831

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 10, 2023

No description provided.

Copy link

github-actions bot commented Nov 10, 2023

😭 Deploy PR Preview failed.

@gsmet
Copy link
Member Author

gsmet commented Nov 10, 2023

@insectengine any chance you could help me? I added a Related content section at the bottom of the guides but I'm struggling to have the type icon aligned with the title of the guide. I tried many things but didn't end up with an acceptable result. At some point I had it aligned but the icon was truncated so it wasn't really better.

To have an example :

Screenshot 2023-11-10 at 15-43-35 Using Hibernate ORM and Jakarta Persistence - main

Tips welcome!

@gsmet
Copy link
Member Author

gsmet commented Nov 10, 2023

/cc @yrodiere FYI

@gsmet
Copy link
Member Author

gsmet commented Nov 13, 2023

@phillip-kruger btw, if you have good ideas on this one ^, they are welcome too.

@insectengine
Copy link
Collaborator

Sorry... I was off Friday and now the preview doesn't work.

@gsmet
Copy link
Member Author

gsmet commented Nov 14, 2023

@insectengine insist a bit on the preview and it should work!

@insectengine
Copy link
Collaborator

@gsmet -

  1. Add "position: absolute;" to the :before should do it.
  2. in the :before, I don't think you need either the background-size nor the background-repeat there either.
Screenshot 2023-11-15 at 12 00 55 PM

@gsmet
Copy link
Member Author

gsmet commented Nov 15, 2023

Thanks so much @insectengine , works like a charm. Will wait for CI and merge!

@gsmet gsmet merged commit b736d3e into quarkusio:develop Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants