Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BR to the Portuguese menu items #1810

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Add BR to the Portuguese menu items #1810

merged 3 commits into from
Oct 11, 2023

Conversation

gastaldi
Copy link
Collaborator

@gastaldi gastaldi commented Oct 9, 2023

  • This makes pt.quarkus.io explicit about being pt_BR and not pt_PT

gastaldi added a commit to gastaldi/extensions that referenced this pull request Oct 9, 2023
@gastaldi
Add Brasileiro to the Portuguese menu items
51678c0 
- Follow up to quarkusio/quarkusio.github.io#1810
@gastaldi gastaldi mentioned this pull request Oct 9, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@gastaldi
Copy link
Collaborator Author

gastaldi commented Oct 9, 2023

Should we keep the longer Brasileiro name or just BR? Either works for me but I think the latter is better since it takes less space, WDYT?

@maxandersen
Copy link
Member

Should we keep the longer Brasileiro name or just BR? Either works for me but I think the latter is better since it takes less space, WDYT?

(BR) fits better. +1 on keeping it short.

@gastaldi gastaldi changed the title Add Brasileiro to the Portuguese menu items Add BR to the Portuguese menu items Oct 11, 2023
@gastaldi gastaldi merged commit 60e2ef6 into quarkusio:develop Oct 11, 2023
1 check passed
@gastaldi gastaldi deleted the ptbr branch October 11, 2023 13:39
holly-cummins pushed a commit to quarkusio/extensions that referenced this pull request Oct 11, 2023
@gastaldi @holly-cummins
Add Brasileiro to the Portuguese menu items
708fc6a 
- Follow up to quarkusio/quarkusio.github.io#1810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen left review comments

@holly-cummins holly-cummins holly-cummins approved these changes

@brunobat brunobat brunobat approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gastaldi @maxandersen @brunobat @holly-cummins