ArC - make it possible to exclude types and dependencies #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Jun 8, 2020
mkouba
commented
- resolves Ability to exclude 3rd party CDI beans/factories from Quarkus Arc bean resolution #9545
boring-cyborg
bot
added
area/arc
aloubyansky
reviewed
Jun 8, 2020
| @@ -12,18 +12,18 @@ | |||
| * The maven groupId of the artifact to index | |||
| */ | |||
| @ConfigItem | |||
| String groupId; | |||
| public String groupId; | |||
There was a problem hiding this comment.
Could this be made an immutable class, btw? Not necessarily in this PR.
There was a problem hiding this comment.
It's a config group. I'm not sure it's possible to make config groups immutable?
aloubyansky
reviewed
Jun 8, 2020
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanProcessor.java
Outdated
Show resolved
Hide resolved
aloubyansky
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
It looks ok to me. A note on paths not associated with a key. I'm wondering whether that could be viewed as an incomplete support of this feature. It could be improved though. If the additional path is a JAR, in the majority of cases it will include Maven metadata which could be used to extract its key. Something to keep in mind.
geoand
reviewed
Jun 9, 2020
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ArcConfig.java
Outdated
Show resolved
Hide resolved
geoand
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.