Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Jackson 2.11.0 #9719

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Bump to Jackson 2.11.0 #9719

merged 1 commit into from
Jun 26, 2020

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jun 2, 2020

No description provided.

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 2, 2020
@gastaldi gastaldi added this to the 1.6.0 - master milestone Jun 2, 2020
@gastaldi gastaldi marked this pull request as ready for review June 2, 2020 02:49
@geoand
Copy link
Contributor

geoand commented Jun 2, 2020

Maybe we should wait for a 2.11.1 or something? Just to be on the safe side?

@Sanne
Copy link
Member

Sanne commented Jun 2, 2020

Looks fine, but is there a specific reason to upgrade? I'd be cautious as so many components integrate with Jackson - but maybe that's just another reason to merge it now, as we're early in the 1.6 cycle.

@gsmet
Copy link
Member

gsmet commented Jun 2, 2020

For Jackson upgrades, I usually ping @cescoffier to be sure it's not an issue on the Vert.x side.

@Sanne Sanne requested a review from cescoffier June 5, 2020 17:20
@gastaldi
Copy link
Contributor Author

gastaldi commented Jun 9, 2020

@cescoffier might you give us your blessing, please? 😉

@gsmet gsmet removed this from the 1.6.0 - master milestone Jun 25, 2020
@cescoffier
Copy link
Member

LGTM

@cescoffier cescoffier merged commit 6a84947 into quarkusio:master Jun 26, 2020
@gastaldi gastaldi deleted the jackson branch June 29, 2020 17:59
@gsmet gsmet modified the milestones: 1.6.0.Final, 1.7.0 - master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@gastaldi @geoand @Sanne @gsmet @cescoffier