Swagger and static resource support AWS Lambda HTTP, Azure HTTP #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/amazon-lambda
area/documentation
area/resteasy-classic
labels
patriot1burke
force-pushed
the
lambda-swagger
branch
from
4b013c8 to
1912d0f
Compare
stuartwdouglas
requested changes
Jun 2, 2020
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Outdated
Show resolved
Hide resolved
patriot1burke
force-pushed
the
lambda-swagger
branch
2 times, most recently
from
52311f8 to
03dfd8c
Compare
|
@oztimpower This has resolved the exception stack trace issues when running with test harness. |
This was referenced Jun 2, 2020
stuartwdouglas
requested changes
Jun 3, 2020
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Show resolved
Hide resolved
...ons-http/runtime/src/main/java/io/quarkus/azure/functions/resteasy/runtime/BaseFunction.java
Show resolved
Hide resolved
patriot1burke
force-pushed
the
lambda-swagger
branch
3 times, most recently
from
e097168 to
d91e04c
Compare
lambda formatting virtual handler poll loop error messages git rid of poll loop fix transferTo revert back
patriot1burke
force-pushed
the
lambda-swagger
branch
from
d91e04c to
2e76ec5
Compare
|
@stuartwdouglas Approve? |
stuartwdouglas
approved these changes
Jun 3, 2020
|
@patriot1burke I'm considering backporting that one to 1.5.1. Does it make sense to you or is it too risky? |
|
There's risk, but go for it. Have to trust our testsuite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not handling static resource correctly in the virtual HTTP layer. This fix will allow swagger support to work with AWS and Azure HTTP extensions as well as any static resource that emits FileRegion's internally.
I also redid the VirtualChannel stuff a bit to avoid context switching. I was having trouble with FileRegions as the VirtualChannel was closing the file before the azure/aws layer could read from the region. Since I was doing too much context switching anyways, I decided to just move message processing to the io loop. This aws/azure message processing is all non-blocking so it should be fine.
@stuartwdouglas Not sure if I handled FileRegions correctly. Can you take a look? They are in a spin loop. It looks like the NioChannel is handling them in the same way.