Support FileRegions for AWS Lambda HTTP and Azure Functions HTTP #9714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested changes
Jun 1, 2020
| FileRegion file = (FileRegion) msg; | ||
| if (file.count() > 0) { | ||
| if (baos == null) | ||
| baos = createByteStream(); |
There was a problem hiding this comment.
I think this will truncate files if the length is larger than the 1000 byte buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quarkus-amazon-lambda-http and quarkus-azure-functions-http did not support FileRegion and things like swagger and other static endpoints were not working.
@stuartwdouglas One issue that popped up with this solution was that there was a race condition. The FileRegion was being closed before the AWS/Azure layer was able to process the message. Ended up having to do some ugly thread synchronization. Not sure if this will be a performance hit or not.