Improve consistency in codegen #9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of quarkusio#8178 The result is just a tiny bit better, this is just a step in my journey. Having more consistency and readability will help in the refactoring process.. - Use only the values in `QuarkusCommandInvocation`, because having the Properties and the Values made it confusing - Make `QuarkusCommandInvocation` more consistent by making it partially immutable (only values are mutable) and enforcing non null params in the constructor - Remove legacy @deprecated stuff
boring-cyborg
bot
added
area/devtools
|
Removing the |
aloubyansky
approved these changes
May 27, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #8178
The result is just a tiny bit better, this is just a step in my journey. Having more consistency and readability will help in the refactoring process..
QuarkusCommandInvocation, because having the Properties and the Values made it confusingQuarkusCommandInvocationmore consistent by making it partially immutable (only values are mutable) and enforcing non null params in the constructor