Refactor the HibernateOrmProcessor to decompose the build steps into … #9362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…smaller items This is necessary to avoid cycles in upcoming fixes
Sanne
force-pushed
the
HibernateOrmProcessor
branch
from
f8a4415 to
87cc14f
Compare
geoand
reviewed
May 19, 2020
| * Exposed as a possible integration API: other extensions can produce additional | ||
| * configuration instances. | ||
| * | ||
| * @author Sanne Grinovero <[email protected]> |
There was a problem hiding this comment.
It would be nice to drop the author tags since we haven't been using them in a while :)
stuartwdouglas
approved these changes
May 19, 2020
There was a problem hiding this comment.
Looks fine to me. There are some @author tags that we don't usually have but I think the final decision there was they were optional rather than not allowed?
|
Thanks all ! Just a note FYI there's plenty of author tags in these modules, introduced by others first so I resumed using them as well. BTW it's more practical for me to have author tags than not: it avoid me needing to swap IDE template settings all the time, as I spend most of my coding time on other projects which expect them. |
|
Honest question: can't the templates be made project specific? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…smaller items
Fixes #9361