Remove testcontainers from BOM #9078
Conversation
boring-cyborg
bot
added
the
area/dependencies
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>postgresql</artifactId> | ||
| <version>${test-containers.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
I see you removed one of the artifact, we don't use it?
There was a problem hiding this comment.
Yes, the junit related artifact wasn't being used anywhere
|
Wondering if maybe we should add test containers to dependabot while we're at it? Looks like the typical artifact we would want to be managed? |
|
Yeah, that makes sense. I'll add another commit |
|
We already had it it seems. I just updated it to reflect the changes of this PR |
|
Taking out of draft since CI passed on my fork |
| @@ -110,7 +110,7 @@ update_configs: | |||
| - match: | |||
| dependency_name: "org.testcontainers:testcontainers" | |||
| - match: | |||
| dependency_name: "org.testcontainers:junit-jupiter" | |||
| dependency_name: "org.testcontainers:postgresql" | |||
There was a problem hiding this comment.
@gastaldi when you're back and you unpile your emails, I have a question for you: does dependabot support wildcards? I couldn't find any information about it. It could be handy for testcontainers to have a wildcard for all the group id for instance.
|
It does not, I opened a ticket for them to add this feature but it was
closed by their stalebot: dependabot/feedback#780
Em Ter, 5 de mai de 2020 07:29, Guillaume Smet <[email protected]>
escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In .dependabot/config.yml
<#9078 (comment)>:
> @@ -110,7 +110,7 @@ update_configs:
- match:
dependency_name: "org.testcontainers:testcontainers"
- match:
- dependency_name: "org.testcontainers:junit-jupiter"
+ dependency_name: "org.testcontainers:postgresql"
@gastaldi <https://github.com/gastaldi> when you're back and you unpile
your emails, I have a question for you: does dependabot support wildcards?
I couldn't find any information about it. It could be handy for
testcontainers to have a wildcard for all the group id for instance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9078 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANG5I746V7OMM7SWDJY6DRP7TATANCNFSM4MZL2VUQ>
.
|
|
So multiple entries it is :) |
Based on the discussion in #9073