Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @ConfigProperties annotated classes to have a super class #8921

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Allow @ConfigProperties annotated classes to have a super class #8921

merged 2 commits into from
Apr 30, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 28, 2020

Fixes: #8917

@boring-cyborg boring-cyborg bot added the area/arc Issue related to ARC (dependency injection) label Apr 28, 2020
@geoand geoand requested a review from mkouba April 28, 2020 15:32
@geoand geoand added this to the 1.5.0 milestone Apr 28, 2020
@geoand
Copy link
Contributor Author

geoand commented Apr 29, 2020 •
edited
Loading

This looks more complicated in the Github UI that it really is. The real change is just to move the property reading bytecode generation into a loop.

A lot more code was devoted to the tests 😉

@geoand
Copy link
Contributor Author

geoand commented Apr 29, 2020

@mkouba could you please take a look?

mkouba
mkouba approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 30, 2020
@geoand geoand merged commit b481287 into quarkusio:master Apr 30, 2020
@geoand geoand deleted the #8917 branch April 30, 2020 14:00
@cmoulliard cmoulliard mentioned this pull request May 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/config triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.5.0.CR1
Development

Successfully merging this pull request may close these issues.

Allow @ConfigProperties annotated classes to have a super class (other than Object)
2 participants
@geoand @mkouba