Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the rest of the Kotlin dependencies to the BOM #8882

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 27, 2020

Done in order to avoid mixing multiple Kotlin versions
in the quarkus-universe-bom

Fixes: #8876

Done in order to avoid mixing multiple Kotlin versions
in the quarkus-universe-bom

Fixes: quarkusio#8876
@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Apr 27, 2020
@geoand geoand requested a review from gsmet April 27, 2020 14:44
@geoand
Copy link
Contributor Author

geoand commented Apr 27, 2020

I didn't add the corroutines library because that's not something we use anywhere... My thinking is that if a user wants to use it, they should be responsible for looking up the version that corresponds to the kotlin version.

@gsmet gsmet marked this pull request as ready for review April 27, 2020 16:15
@geoand geoand merged commit b02cdaa into quarkusio:master Apr 28, 2020
@geoand geoand deleted the #8876 branch April 28, 2020 05:21
@gsmet gsmet added this to the 1.4.2.Final milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus 1.4.1.Final includes kotlin versions 1.3.72 and 1.3.61 at the same time
2 participants