Add the allowed values for quarkus.kubernetes.service-type #8827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't optimal, but it's better than not having them at all which is currently the case... |
gsmet
requested changes
Apr 24, 2020
geoand
force-pushed
the
k8s-servicetype-docs
branch
from
421e17d to
130e646
Compare
machi1990
approved these changes
Apr 24, 2020
machi1990
added a commit
to machi1990/quarkus
that referenced
this pull request
Apr 24, 2020
Following this comment quarkusio#8827 (comment) where we realized the need to make sure that default values are also hyphenated with two exceptions: 1) for a config item annotated with `@DefaultConverter` where we could just display the enum name a.k.a use SmallRye config default converters 2) And when a config item is annotated with `@ConvertWith` where we are not sure of the converter type to use.
|
@gsmet OK to merge? |
gsmet
approved these changes
Apr 24, 2020
gwenneg
pushed a commit
to gwenneg/quarkus
that referenced
this pull request
May 2, 2020
Following this comment quarkusio#8827 (comment) where we realized the need to make sure that default values are also hyphenated with two exceptions: 1) for a config item annotated with `@DefaultConverter` where we could just display the enum name a.k.a use SmallRye config default converters 2) And when a config item is annotated with `@ConvertWith` where we are not sure of the converter type to use.
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this pull request
Sep 4, 2022
Following this comment quarkusio/quarkus#8827 (comment) where we realized the need to make sure that default values are also hyphenated with two exceptions: 1) for a config item annotated with `@DefaultConverter` where we could just display the enum name a.k.a use SmallRye config default converters 2) And when a config item is annotated with `@ConvertWith` where we are not sure of the converter type to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.