Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set defaults values for Page number and size #8652

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

aureamunoz
Copy link
Member

Fix UnsupportedOperationException when Unpaged element is used
WDYT @geoand ?

@boring-cyborg boring-cyborg bot added area/hibernate-orm Hibernate ORM area/spring Issues relating to the Spring integration labels Apr 17, 2020
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Thanks a lot!

@geoand
Copy link
Contributor

geoand commented Apr 18, 2020

Please rebase PR onto the latest master in order to pick up a CI fix

@gastaldi gastaldi added this to the 1.5.0 milestone Apr 19, 2020
@aureamunoz aureamunoz force-pushed the fix-Unpaged-exception branch from cc10122 to 914aa15 Compare April 20, 2020 06:31
gsmet
gsmet previously requested changes Apr 20, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to dismiss if everything is fine.

@geoand
Copy link
Contributor

geoand commented Apr 20, 2020

@aureamunoz #8162 was merged, so please rebase onto that before doing anything else :).

@aureamunoz aureamunoz force-pushed the fix-Unpaged-exception branch from 426f702 to 65ebc37 Compare April 21, 2020 14:26
@aureamunoz
Copy link
Member Author

Let me know if it's better now

@geoand
Copy link
Contributor

geoand commented Apr 21, 2020

@aureamunoz looks good. But please squash the commits, then we can merge.

@aureamunoz aureamunoz force-pushed the fix-Unpaged-exception branch from 65ebc37 to 6bf6efb Compare April 21, 2020 14:38
@aureamunoz
Copy link
Member Author

done

@geoand geoand dismissed gsmet’s stale review April 21, 2020 14:40

comment has been addressed

@geoand geoand merged commit 74d8d16 into quarkusio:master Apr 22, 2020
@gsmet gsmet modified the milestones: 1.5.0, 1.4.0.Final Apr 22, 2020
@snowdrop-bot snowdrop-bot mentioned this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/spring Issues relating to the Spring integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants