-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentracing take2 (OKAY TO MERGE) #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
opentracing-take2
branch
2 times, most recently
from
November 14, 2018 04:06
de6ce81
to
c10cc19
Compare
stuartwdouglas
force-pushed
the
opentracing-take2
branch
from
November 14, 2018 05:26
c10cc19
to
42c24f0
Compare
I'm okay to merge this and continue to refine it along the way. It "works" currently. |
bobmcwhirter
changed the title
Opentracing take2 (DO NOT MERGE)
Opentracing take2 (OKAY TO MERGE)
Nov 14, 2018
thanks @bobmcwhirter , I'll click the merge button then :) Incidentally while I don't see any test failure, the build logs a solid amount of exceptions, all looking like this :
|
Yah. That’s how I Debug. I’ll clean that ish up in another PR.
…On Wed, Nov 14, 2018 at 11:00 AM Sanne Grinovero ***@***.***> wrote:
thanks @bobmcwhirter <https://github.com/bobmcwhirter> , I'll click the
merge button then :)
Incidentally while I don't see any test failure, the build logs a solid
amount of exceptions, all looking like this :
ASK FOR TRACER
java.lang.Exception
at java.lang.Throwable.<init>(Throwable.java:250)
at java.lang.Exception.<init>(Exception.java:54)
at org.jboss.shamrock.opentracing.runtime.ShamrockTracer.tracer(ShamrockTracer.java:35)
at org.jboss.shamrock.opentracing.runtime.ShamrockTracer.buildSpan(ShamrockTracer.java:89)
at io.opentracing.contrib.jaxrs2.server.ServerTracingFilter.filter(ServerTracingFilter.java:67)
at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:312)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA-T5Z3DnzSkUiU-rui4OtjqNzdr2-lks5uvD4MgaJpZM4YchF0>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.