Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentracing take2 (OKAY TO MERGE) #86

Merged
merged 5 commits into from
Nov 14, 2018
Merged

Opentracing take2 (OKAY TO MERGE) #86

merged 5 commits into from
Nov 14, 2018

Conversation

bobmcwhirter
Copy link
Contributor

No description provided.

@stuartwdouglas stuartwdouglas force-pushed the opentracing-take2 branch 2 times, most recently from de6ce81 to c10cc19 Compare November 14, 2018 04:06
@bobmcwhirter
Copy link
Contributor Author

I'm okay to merge this and continue to refine it along the way.

It "works" currently.

@bobmcwhirter bobmcwhirter changed the title Opentracing take2 (DO NOT MERGE) Opentracing take2 (OKAY TO MERGE) Nov 14, 2018
@Sanne
Copy link
Member

Sanne commented Nov 14, 2018

thanks @bobmcwhirter , I'll click the merge button then :)

Incidentally while I don't see any test failure, the build logs a solid amount of exceptions, all looking like this :

ASK FOR TRACER
java.lang.Exception
	at java.lang.Throwable.<init>(Throwable.java:250)
	at java.lang.Exception.<init>(Exception.java:54)
	at org.jboss.shamrock.opentracing.runtime.ShamrockTracer.tracer(ShamrockTracer.java:35)
	at org.jboss.shamrock.opentracing.runtime.ShamrockTracer.buildSpan(ShamrockTracer.java:89)
	at io.opentracing.contrib.jaxrs2.server.ServerTracingFilter.filter(ServerTracingFilter.java:67)
	at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:312)

@Sanne Sanne merged commit 89ad3dd into master Nov 14, 2018
@Sanne Sanne deleted the opentracing-take2 branch November 14, 2018 16:00
@bobmcwhirter
Copy link
Contributor Author

bobmcwhirter commented Nov 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants