#6549 - Apache Tika can not parse Microsoft Docx format in native mode #7198

tpenakov · 2020-02-14T12:00:48Z

Fixes: #6549
A few things to points out:

xalan dependency is included - probably on wrong place: extensions/arc/runtime/pom.xml
additional config property is added for supported file types - we have support for pptx ans xlsx file types as well, however if we include all of them - the native build ends with OOM error.
Trying to use @ConfigProperty in io.quarkus.it.tika.TikaEmbeddedContentTest leads to NPE for native build. This one (@ConfigProperty without @Inject does not work in test #2061) claims that is fixed, but I am receiving it.

…ative mode

geoand · 2020-02-14T12:30:45Z

bom/runtime/pom.xml

@@ -2762,6 +2775,32 @@
                <artifactId>quarkus-banner</artifactId>
                <version>${project.version}</version>
            </dependency>
+
+            <!-- reflections -->
+            <dependency>


I am pretty sure we don't want to add this dependency to the core. We have basically done without it for all this time, so I don't really think it's warranted to add it now.

Hi @geoand - if you check the code the reflection framework is used in more than one place. I've just put it on more centralized place. Anyway - what I've tried to achieve here is to register for reflection all classes in given package. Could you please advice is there an other way to achieve it?

We use Jandex instead to query the application classes structures, see the examples in other extensions

@tpenakov like @gastaldi said, we usually don't use reflection in Quarkus extensions but instead rely on Jandex (which is effectively an index for Java code) to look up various metadata.

One question, do you really need to register all classes of a package for reflection?

Hi @geoand ,

The package which I want to register contains the implementation of components for parsing docx format (org.openxmlformats.schemas.wordprocessingml.x2006.main.impl). Also will need to include all classes in packagess for parsing xlsx and pptx components.
I've tried to google this for Jandex, but without success. If you know how to do it in Jandex (to register all classes for given package) - this will save me a lot of time and I will remove the reflection framework :)

I don't think Jandex does this TBH. If you must register all classes in a package for reflection, then sure go ahead and use the reflections module (if @sberyozkin agrees), but please only use it in your extension and no where else

Hi @geoand , @gastaldi and @sberyozkin,
Reflections maven artifact is now moved under the tika-deployment.

gastaldi · 2020-02-14T12:37:31Z

extensions/arc/runtime/pom.xml

@@ -27,6 +27,17 @@
      <groupId>org.eclipse.microprofile.context-propagation</groupId>
      <artifactId>microprofile-context-propagation-api</artifactId>
    </dependency>
+    <dependency>
+      <groupId>xalan</groupId>


Why ARC needs to depend on Xalan?

Hi @gastaldi ,
If I put it on the other places the tika-integration-tests are failed.
I've added a few more notes it he PR description.

gastaldi · 2020-02-14T12:38:16Z

core/deployment/src/main/java/io/quarkus/deployment/util/ReflectUtil.java

+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
+
+import java.lang.reflect.*;


We don't use star imports, make sure to use the IDE config file as described in https://github.com/quarkusio/quarkus/blob/master/CONTRIBUTING.md#ide-config-and-code-style

You were right @gastaldi -the IDE config file wasn't included. Now it is, however the wildcard import is still there :(

gastaldi · 2020-02-14T12:39:30Z

core/deployment/pom.xml

@@ -79,6 +79,10 @@
            <type>test-jar</type>
            <scope>test</scope>
        </dependency>
+        <dependency>


As @geoand mentioned, I don't think it's a good idea to add this library to core

Hi @gastaldi ,
if you check the code the reflection framework is used in more than one place. I've just put it on more centralized place. Anyway - what I've tried to achieve here is to register for reflection all classes in given package. Could you please advice is there an other way to achieve it?

Not a problem to move it only on Tika related deploynment, but as I said this library is used on more than one place. In my experience if such things is happened, we have to move the dependency on more centralized place, or to not used it at all and to replace it with the similar functionality.

gastaldi · 2020-02-14T12:40:57Z

extensions/tika/runtime/pom.xml

+            <exclusions>
+                <exclusion>
+                    <groupId>org.apache.xmlbeans</groupId>
+                    <artifactId>xmlbeans</artifactId>
+                </exclusion>
+            </exclusions>


You can remove this exclusion and the dependency below (since it's resolved transitively)

Hi @gastaldi - There was a difference in the versions of XML Beans. I found only this way to deal with it.

sberyozkin · 2020-02-14T13:16:57Z

@tpenakov Thanks for giving it a go, appreciated. I agree though with @geoand and @gastaldi is that the way it is done it would cause too many side-effects. Let me try to find some time asap and experiment with your PR locally, I'll keep you uptodate, thank you !

tpenakov · 2020-02-16T09:26:07Z

Thank you @sberyozkin - I've added some comments/answers to @geoand and @gastaldi and added and the explanations in the PR. I also have some concerns (written in PR description)

…ative mode - move reflections maven artifact under the tika-deployment module

gsmet · 2020-10-12T09:55:51Z

Closing this one as out of date. Let's create a new PR if we still need it.

quarkusio#6549 - Apache Tika can not parse Microsoft Docx format in n…

b672da3

…ative mode

boring-cyborg bot added area/arc Issue related to ARC (dependency injection) area/core area/dependencies Pull requests that update a dependency file area/tika labels Feb 14, 2020

tpenakov mentioned this pull request Feb 14, 2020

Apache Tika can not parse Microsoft Docx format in native mode #6549

Closed

geoand requested a review from sberyozkin February 14, 2020 12:26

geoand reviewed Feb 14, 2020

View reviewed changes

gastaldi reviewed Feb 14, 2020

View reviewed changes

quarkusio#6549 - Apache Tika can not parse Microsoft Docx format in n…

1de0cba

…ative mode - move reflections maven artifact under the tika-deployment module

galderz mentioned this pull request Mar 26, 2020

Add missing ooxml-schemas dependency #8081 #8185

Merged

gsmet closed this Oct 12, 2020

gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Oct 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#6549 - Apache Tika can not parse Microsoft Docx format in native mode #7198

#6549 - Apache Tika can not parse Microsoft Docx format in native mode #7198

tpenakov commented Feb 14, 2020 •

edited

Loading

geoand Feb 14, 2020

tpenakov Feb 16, 2020

gastaldi Feb 16, 2020

geoand Feb 17, 2020

tpenakov Feb 17, 2020

geoand Feb 17, 2020

tpenakov Feb 18, 2020

gastaldi Feb 14, 2020

tpenakov Feb 16, 2020 •

edited

Loading

gastaldi Feb 14, 2020

tpenakov Feb 16, 2020

gastaldi Feb 14, 2020

tpenakov Feb 16, 2020

gastaldi Feb 14, 2020

tpenakov Feb 16, 2020

sberyozkin commented Feb 14, 2020 •

edited

Loading

tpenakov commented Feb 16, 2020

gsmet commented Oct 12, 2020

#6549 - Apache Tika can not parse Microsoft Docx format in native mode #7198

#6549 - Apache Tika can not parse Microsoft Docx format in native mode #7198

Conversation

tpenakov commented Feb 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tpenakov Feb 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sberyozkin commented Feb 14, 2020 • edited Loading

tpenakov commented Feb 16, 2020

gsmet commented Oct 12, 2020

tpenakov commented Feb 14, 2020 •

edited

Loading

tpenakov Feb 16, 2020 •

edited

Loading

sberyozkin commented Feb 14, 2020 •

edited

Loading