Turn a class annotated with @Startup but no scope into a bean #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Feb 7, 2020
mkouba
commented
- add @ApplicationScope automatically
- resolves Allow the standalone use of @Startup #7048
- add @ApplicationScope automatically - resolves quarkusio#7048
boring-cyborg
bot
added
area/arc
geoand
approved these changes
Feb 7, 2020
manovotn
reviewed
Feb 7, 2020
|
|
||
| @Override | ||
| public void transform(TransformationContext context) { | ||
| if (context.isClass() && !BuiltinScope.isDeclaredOn(context.getTarget().asClass())) { |
There was a problem hiding this comment.
I know it's somewhat far-fetched but should we care about non-built in scopes? Users can have custom ones, or there is Transactional one already present. Both cases will pass this check and try to add yet another scope on the bean (which should later on blow up).
There was a problem hiding this comment.
That's a good point. Although in this case I doubt that a @Startup bean would be annotated with @Transactional or a custom scope. Let's create a separate issue to handle this corretly. WDYT?
There was a problem hiding this comment.
Hm, the problem is that annotation transformers are registered before the final set of scopes is known...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.