Simplify Mongo client #6720
Simplify Mongo client #6720
Conversation
MongoClientBuildItem is not used anywhere neither are the RuntimeValue values produced by the recorder
| launchMode.getLaunchMode(), shutdown, | ||
| codecs.getCodecProviderClassNames()); | ||
| RuntimeValue<ReactiveMongoClient> reactiveClient = recorder.configureTheReactiveClient(); | ||
| return new MongoClientBuildItem(client, reactiveClient); |
There was a problem hiding this comment.
That allows another extension to get the client. Why removing this feature?
Not sure if Panache Mongo requires it But I had something using this (for demo purpose, so no problem to break it).
There was a problem hiding this comment.
Mongo Panache is not using this (at least as far as I could tell and when I ran the tests locally nothing failed).
I removed it because nothing was using it and the implementation threw me off. If you feel it's valid to keep it around for future use, then I have absolutely no problem closing this PR
|
MongoDB with Panache didn't use it but maybe it should to be sure that the client is initialized before it. For the record, HIbernate with Panache uses the This is also changed by the PR that provides multiple MongoDB Client support : #4529 ... better not merging this before it as it would need again a rebased ... |
|
Yeah, let's see what #4529 does and I'll update this PR accordingly (or close it) |
|
I had a request to expose the |
|
I'll check with Camel as well. If it's not used, then I don't really see the point of keeping it around |
|
Well, it might be a good idea to check if they would be interested and if we should generalize things like that instead of removing them. |
|
That's a good idea. I'll see what's up on that side of things |
|
This pattern lets us manage the "I'm using Vert.x before you" issue we had when injecting Vert.x instances or the router instances. So, I believe it should be generalized. It does not cost much and allows extensions to be called once their dependencies are ready. |
|
Closing this as Camel uses it |
MongoClientBuildItem is not used anywhere neither
are the RuntimeValue values produced by the recorder