Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Deprecate enableJni option and always consider it true #6306

Closed
wants to merge 1 commit into from
Closed

[WIP] Deprecate enableJni option and always consider it true #6306

wants to merge 1 commit into from

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Dec 21, 2019

Fixes #6101

This PR is ready for a review, but it shouldn't be merged into master before we're sure that the following Quarkus release depends on GraalVM 19.3.0 or greater.

@gwenneg gwenneg added the triage/on-ice Frozen until external concerns are resolved label Dec 21, 2019
@gwenneg gwenneg changed the title Deprecate enableJni option and always consider it true [WIP] Deprecate enableJni option and always consider it true Dec 21, 2019
@gwenneg
Copy link
Member Author

gwenneg commented Dec 21, 2019 •
edited
Loading

I'm putting a WIP tag in the title to make sure it isn't merged too soon.

@gwenneg gwenneg added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Dec 24, 2019
@gwenneg gwenneg requested a review from gsmet January 2, 2020 13:34
gsmet
gsmet approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I agree we need to merge it very last minute.

I'm still unsure we will be able to have the RSS regression fixed in 19.3.1.

@gwenneg
Copy link
Member Author

gwenneg commented Jan 2, 2020

Thanks for the review!

@gsmet
Copy link
Member

gsmet commented Jan 8, 2020

If we get to support both versions, we will have to tune that one a bit.

@gwenneg gwenneg mentioned this pull request Jan 16, 2020
Merged
@gwenneg
Copy link
Member Author

gwenneg commented Jan 25, 2020

Superseded by #6792.

@gwenneg gwenneg closed this Jan 25, 2020
@gwenneg gwenneg added triage/invalid This doesn't seem right and removed triage/on-ice Frozen until external concerns are resolved labels Jan 25, 2020
@gwenneg gwenneg mentioned this pull request Jan 26, 2020
Merged
@gwenneg gwenneg deleted the issue-6101-deprecate-enable-jni branch February 1, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate enableJni option as GraalVM 19.3 requires JNI support
2 participants
@gwenneg @gsmet