Fix failing tests in master #5410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Nov 12, 2019
cescoffier
reviewed
Nov 12, 2019
| String CONTENT = "html content"; | ||
| test.addResourceFile(META_INF_RESOURCES + "index2.html", CONTENT); | ||
|
|
||
| Thread.sleep(700); |
There was a problem hiding this comment.
wouldn't it be better to use Awaitibility and poll until it passes?
There was a problem hiding this comment.
Await on the RestAssured call passing?
And then have a max time of 2 seconds?
Is that preferred? I can adjust
There was a problem hiding this comment.
We currently don't have Awaitility as a dependency, is it ok to add?
There was a problem hiding this comment.
I have extensions using it I believe.
There was a problem hiding this comment.
ugh, I was looking at the wrong BOM!
There was a problem hiding this comment.
Tried switching to awaitility, and it has a failure with one, not entirely sure why
There was a problem hiding this comment.
Awaitility seems to lead to just as much raciness unfortunately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the fix isn't ideal, as it adds sleep, but any alternative suggestions are appreciated