Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call the health check method on the worker pool #4549

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Call the health check method on the worker pool #4549

merged 1 commit into from
Oct 14, 2019

Conversation

cescoffier
Copy link
Member

Fix #4531

@cescoffier cescoffier added this to the 0.25.0 milestone Oct 14, 2019
kenfinnigan
kenfinnigan previously approved these changes Oct 14, 2019
View reviewed changes
@cescoffier cescoffier force-pushed the features/health-check-blocking branch from a3bb1e7 to 4838885 Compare October 14, 2019 13:08
gsmet
gsmet previously requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking this thing so that nobody merges it by mistake as it has been approved.

Please dismiss once everything is ready.

@kenfinnigan kenfinnigan dismissed their stale review October 14, 2019 13:16

Changes made

@stuartwdouglas stuartwdouglas added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2019
@cescoffier cescoffier force-pushed the features/health-check-blocking branch 3 times, most recently from 63bd63d to 3b073cd Compare October 14, 2019 14:08
@cescoffier
Fix quarkusio#4531
c375339 
As stated in the issue, the request scope must also be activated.
@cescoffier cescoffier force-pushed the features/health-check-blocking branch from 3b073cd to c375339 Compare October 14, 2019 14:28
@cescoffier
Copy link
Member Author

@gsmet changes have been made.

@kenfinnigan kenfinnigan merged commit 235ed78 into quarkusio:master Oct 14, 2019
@kenfinnigan kenfinnigan removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2019
@cescoffier cescoffier deleted the features/health-check-blocking branch January 21, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba left review comments

@kenfinnigan kenfinnigan kenfinnigan left review comments

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Health check called on the event loop
5 participants
@cescoffier @stuartwdouglas @kenfinnigan @mkouba @gsmet