Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump org.junit:junit-bom from 5.10.5 to 5.11.4 in /devtools/gradle" #45200

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Revert "Bump org.junit:junit-bom from 5.10.5 to 5.11.4 in /devtools/gradle" #45200

merged 1 commit into from
Dec 19, 2024

Conversation

gastaldi
Copy link
Contributor

Reverts #45152

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Dec 19, 2024
@gastaldi gastaldi requested review from gsmet and geoand December 19, 2024 10:28
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 19, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 19, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7dd16de.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@geoand
Copy link
Contributor

geoand commented Dec 19, 2024

Are all things in place now that we can include it?

@gastaldi
Copy link
Contributor Author

We're not including it, I'm reverting this version which failed when running the Maven build

@geoand
Copy link
Contributor

geoand commented Dec 19, 2024

Ah sorry, miread it

@gastaldi gastaldi merged commit d34b810 into main Dec 19, 2024
38 of 39 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 19, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 19, 2024
@gastaldi gastaldi deleted the revert-45152-dependabot/gradle/devtools/gradle/org.junit-junit-bom-5.11.4 branch December 19, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.
2 participants
@gastaldi @geoand