Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use custom handlers for HTTP OPTIONS method in subresources #45174

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Unable to use custom handlers for HTTP OPTIONS method in subresources #45174

merged 1 commit into from
Dec 18, 2024

Conversation

mabartos
Copy link
Contributor

@gsmet gsmet requested a review from geoand December 17, 2024 14:08
geoand
geoand approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@mabartos
Copy link
Contributor Author

@geoand Ahh, I had to run the formatter to pass validations.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 18, 2024
@FroMage
Copy link
Member

FroMage commented Dec 18, 2024

You need to rebase this on the latest main if you want quickstarts to compile. Otherwise ignore the issue of quickstarts if the only problem is webauthn because this is working on the latest main tips on both repos.

@geoand
Copy link
Contributor

geoand commented Dec 18, 2024

Thanks for checking @FroMage!

I rebased the PR, so let's see what happens

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 18, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 349d540.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 8a8aec2 into quarkusio:main Dec 18, 2024
46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 18, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/rest kind/bugfix triage/backport triage/backport-3.15
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.

Unable to use custom handlers for HTTP OPTIONS method in subresources
4 participants
@mabartos @FroMage @geoand @cescoffier