Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JFR integration in Quarkus REST #45059

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Improve JFR integration in Quarkus REST #45059

merged 1 commit into from
Dec 16, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 11, 2024 •
edited
Loading

We are now able to capture events for all
HTTP requests that are meant to be handled
by Quarkus REST, whether they were successfully
handled or not.

@geoand
Improve JFR integration in Quarkus REST
21a9657 
We are now able to capture events for all
HTTP requests that are meant to be handled
by Quarkus REST, whether they were successfully
handled or not.

Fixes: quarkusio#44976
@geoand geoand mentioned this pull request Dec 11, 2024
Closed
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 11, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 21a9657.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand requested review from brunobat and gsmet December 11, 2024 13:30
@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2024

🙏🏽

@geoand geoand merged commit 45449a2 into quarkusio:main Dec 16, 2024
46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 16, 2024
@geoand geoand deleted the #44976 branch December 16, 2024 14:40
@andrewazores
Copy link

Can/will this be backported to 3.15?

@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2024

Unfortunately it's a little too risky for 3.15. What we can do for 3.15 is have a dedicated bug fix that will just prevent the NPE for occuring

@andrewazores
Copy link

Sounds good. So for 3.15 there will still not be a JFR event recorded, but the original expected status code (ex. 404, 405, 406) will be sent?

@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2024

Yeah, that's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@brunobat brunobat Awaiting requested review from brunobat

Assignees
No one assigned
Labels
area/rest kind/bugfix
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.

quarkus-jfr can cause a NullPointerException
3 participants
@geoand @andrewazores @gsmet