Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start Keycloak Dev Service for OIDC client and other extensions when OIDC extension is configured with a known social provider #44980

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 7, 2024

Copy link

quarkus-bot bot commented Dec 7, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should count at least 2 words to describe the change properly
  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/oidc label Dec 7, 2024
@michalvavrik michalvavrik changed the title Don' Don't start Keycloak Dev Service for OIDC client and others when OIDC extension has configured known social provider Dec 7, 2024
@michalvavrik michalvavrik changed the title Don't start Keycloak Dev Service for OIDC client and others when OIDC extension has configured known social provider Don't start Keycloak Dev Service for OIDC client and other extensions when OIDC extension has configured known social provider Dec 7, 2024
@michalvavrik michalvavrik changed the title Don't start Keycloak Dev Service for OIDC client and other extensions when OIDC extension has configured known social provider Don't start Keycloak Dev Service for OIDC client and other extensions when OIDC extension is configured with a known social provider Dec 7, 2024
Copy link

quarkus-bot bot commented Dec 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 89c7131.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik

@sberyozkin sberyozkin merged commit 47567e7 into quarkusio:main Dec 7, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 7, 2024
@michalvavrik michalvavrik deleted the feature/dont-start-kc-dev-svc-when-oidc-fine branch December 7, 2024 12:23
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.4 Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak devservice can be started indirectly if quarkus-oidc uses quarkus.oidc.provider
3 participants